Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UA locale #793

Merged
merged 4 commits into from
Dec 17, 2024
Merged

UA locale #793

merged 4 commits into from
Dec 17, 2024

Conversation

OleksiiGerasymenko
Copy link
Contributor

@OleksiiGerasymenko OleksiiGerasymenko commented Jan 8, 2024

Ukraine locale

Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #793 will not alter performance

Comparing OleksiiGerasymenko:master (5ca1f02) with master (3e3fec6)

Summary

✅ 1 untouched benchmarks

@ALERTua
Copy link

ALERTua commented Jan 16, 2024

I would love to see my language in my favorite Python module!

@Secrus
Copy link
Collaborator

Secrus commented Jan 16, 2024

I would love to see my language in my favorite Python module!

I would love to merge it, but as you can see, CI currently fails. Once it's fixed, it can be merged.

@OleksiiGerasymenko
Copy link
Contributor Author

@Secrus @ALERTua can you help to fix this pls

@ALERTua
Copy link

ALERTua commented Jan 19, 2024

I am sorry, the linting error seems not very informative to me. There is a trailing whitespace, but where? Maybe @Secrus could help.

@drtwisted
Copy link

Ping? Any updates on this?

@ALERTua
Copy link

ALERTua commented Dec 5, 2024

kind reminder

@Secrus
Copy link
Collaborator

Secrus commented Dec 5, 2024

Once it is rebased and pipelines are green I don't see any issue with merging it.

@ALERTua
Copy link

ALERTua commented Dec 5, 2024

@OleksiiGerasymenko ping :)

@Secrus Secrus closed this Dec 17, 2024
@Secrus Secrus reopened this Dec 17, 2024
@Secrus Secrus merged commit a69761e into python-pendulum:master Dec 17, 2024
16 of 17 checks passed
@OleksiiGerasymenko
Copy link
Contributor Author

OleksiiGerasymenko commented Dec 19, 2024

Bardzo dziękuję!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants